Download - Code Reviews

Transcript
Page 1: Code Reviews

page 1 | www.ciber.com | ©2009

Code Reviews

Mattias KarlssonMattias Karlsson

www.linkedin.com/in/mattiasktwitter: @matkar

[email protected]

Page 2: Code Reviews

page 2 | www.ciber.com | ©2009

Code Reviews – Why?

• Increase Quality• Reduce Defects• Increase Team Spirit

Page 3: Code Reviews

page 3 | www.ciber.com | ©2009

Anti Pattern #1

Formal Review Process

Page 4: Code Reviews

page 4 | www.ciber.com | ©2009

Anti Pattern #2

Architect Reviews Everything

Page 5: Code Reviews

page 5 | www.ciber.com | ©2009

What about

Pair Programming

Page 6: Code Reviews

page 6 | www.ciber.com | ©2009

Change purpose

Shareknowledge

Page 7: Code Reviews

page 7 | www.ciber.com | ©2009

My Recipe

• Formal Standards / Code Conventions– Checked by tools

Page 8: Code Reviews

page 8 | www.ciber.com | ©2009

Mattias recipe continued…

• Code review meeting 1-2 hour/week– Code Review Day– Informal Code Review– Code Walkthrough– Introduce review roles – Involve Experts– Involve Newbie's– Make Reviews Constructive Not Caustic– Make Reviews Fun

Page 9: Code Reviews

page 9 | www.ciber.com | ©2009

The 97 Things Book...

Page 10: Code Reviews

page 10 | www.ciber.com | ©2009

Contact

Mattias KarlssonMattias Karlsson

www.linkedin.com/in/mattiasktwitter: @matkar

[email protected]


Top Related