code reviews
DESCRIPTION
Code Reviews - A Thing Every Programmer Should KnowTalare är Mattias Karlsson från CIBERTRANSCRIPT
page 1 | www.ciber.com | ©2009
Code Reviews
Mattias KarlssonMattias Karlsson
www.linkedin.com/in/mattiasktwitter: @matkar
page 2 | www.ciber.com | ©2009
Code Reviews – Why?
• Increase Quality• Reduce Defects• Increase Team Spirit
page 3 | www.ciber.com | ©2009
Anti Pattern #1
Formal Review Process
page 4 | www.ciber.com | ©2009
Anti Pattern #2
Architect Reviews Everything
page 5 | www.ciber.com | ©2009
What about
Pair Programming
page 6 | www.ciber.com | ©2009
Change purpose
Shareknowledge
page 7 | www.ciber.com | ©2009
My Recipe
• Formal Standards / Code Conventions– Checked by tools
page 8 | www.ciber.com | ©2009
Mattias recipe continued…
• Code review meeting 1-2 hour/week– Code Review Day– Informal Code Review– Code Walkthrough– Introduce review roles – Involve Experts– Involve Newbie's– Make Reviews Constructive Not Caustic– Make Reviews Fun
page 9 | www.ciber.com | ©2009
The 97 Things Book...
page 10 | www.ciber.com | ©2009
Contact
Mattias KarlssonMattias Karlsson
www.linkedin.com/in/mattiasktwitter: @matkar