code reviews - leave your ego at the door

Code Peer Reviews

Leave your ego at the door

Frank SonsSenior Software Engineer

So, what’s this about?

2

Introducing Reviews

Collective code ownership

Some ways to review code

Beware the dragons!

3

A short introduction to reviewsForget about the code for the moment…

What’s the idea?

4

Peer review methods are employed to maintain standards, improve

performance and provide credibility.

Reviews aren’t limited to code…

5

Back to code reviews…

6

IBM: Inspection introduced in 1970s

Google: 20% rule used for reviews

7

„That‘s not my code!“Collective code ownership is a mindset

What about the ego?

8

„Everyone has the right and freedom to totally suck in private.“

Forget about your ego!

9

„Attempt to be awesome in public and embrace the suck!“

Reviews are knowledge sharing!

10

Share within your team…

11

Product knowledge

Technical knowledge

Coding Standards

Transparency

12

How to reviewA comprehensive overview

Ad hoc

13

Just ask someone

Takes only a few minutes

Happens everywhere

Little impact beyond problem

Completely informal

Peer deskcheck / passaround

14

Asking someone for input

Can be done asynchronous

Author is not present

Good for mentoring and coaching

Very informal

Pair programming

15

Agile approach

Driver and navigator

Rapid iterations

Cultural change needed

Informal review

Walkthrough

16

Author explains code

Code reading

Ideal to present and educate

Risk of overlooking critical code

Informal, no defined process

Team review

17

Used to judge product

Check against specifications

Preparation needed

Review collects data and input

Planned and structured

Inspection

18

Most formal approach

Industry standard

Specific roles and trained inspectors

Checklist

Moderated review

“Inspection Walkthrough”

19

Reader doesn‘t know code

Experienced dev for „eagle eye“ view

Author explains and answers questions

Specific code section

No leads involved

20

Beware the dragons!It can be tricky…

Egoless!

21

My ego is not tied to my „perfect“ or „imperfect“ work product.

Avoid the dragons

22

No fingerpointing

Leave the egos at the door

Resistance to change

Lack of knowledge

Cultural issues

Some things to keep in mind

23

Three to seven participants

Not longer than two hours

Manager should be involved in planning

Find problems, not solutions

Review coverage vs. project size

24

JUST DO IT!

This helps…

25

I hope you had a good time!

26

Reviews can help your team

Reviews are all about the mindset

Don‘t fear the dragons

27

Thanks!

Find us on

28

Bigpoint GmbHFrank Sons

Senior Software Engineer

Drehbahn 47-4820354 Hamburg

Germany

Tel +49 40.88 14 13 - 0Fax +49 40.88 14 13 - 11

f.sons@bigpoint.netwww.bigpoint.net