how reviewing code makes me a better programmer!
TRANSCRIPT
How$reviewing$codemakes&me&a&be(er&programmer!
Amy$Hanlon@amygdalama
receive&be(er&reviewsbecome&a&be(er&reviewerget$more$value$out$of$code$review
Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4.✨+ask+clarifying+ques=ons+✨
5.✨+offer+sugges=ons+✨
Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4.✨+ask+clarifying+ques=ons+✨
5.✨+offer+sugges=ons+✨
give%context
make%small%changes
Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4.✨+ask+clarifying+ques=ons+✨
5.✨+offer+sugges=ons+✨
use$lin(ng$tools
Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4.✨+ask+clarifying+ques=ons+✨
5.✨+offer+sugges=ons+✨
write&tests
QA#your#changes
Recap:'authors1.#give#context
2.#make#small#changes3.#use#lin*ng#tools
4.#write#tests5.#QA#your#changes
Authors
say$how$done$you$are
ask$for$specific$feedback
get$feedback$early$and$o0en
but$don't$work$too$far$upstream
get$a$micro+yes
welcome'ques+ons
Recap:'authors1.#say#how#done#you#are
2.#ask#for#specific#feedback3.#get#feedback#early#and#o2en
4.#but#don't#work#too#far#upstream5.#get#a#micro-yes
6.#welcome#ques-ons
Reviewers
review&at&the&right&level&of&detail
if#the#code#is#confusing,it's%a%problem%with%the%code...or$an$opportunity$to$learn!
beta%test'your'feedback
communicate*the*why,
not$the$how
Recap:'reviewers1.#review#at#the#right#level#of#detail2.#if#the#code#is#confusing,#it's#a#problem#with#the#code
...or$an$opportunity$to$learn!3.#beta(test#your#feedback4.#communicate#the#why,#not#the#how
receive&be(er&reviewsbecome&a&be(er&reviewerget$more$value$out$of$code$review
Thanks!Julia&Evans
Kamal%Marhubi
Sasha%Laundy
Tania%Luna
A.#Jesse#Jiryu#Davis
Thank&you!Amy$Hanlon
@amygdalama
Resources(&(Related(Reading• Death'to'the'Rubber'Stamp'(or:'ques4ons'I'ask'myself'when'reviewing)'h@p://mathamy.com/deathEtoEtheErubberEstamp.html
• The'Gentle'Art'of'Patch'Review'h@p://sarah.thesharps.us/2014/09/01/theEgentleEartEofEpatchEreview/
• Your'Brain's'API:'Giving'and'GeRng'Technical'Help'h@p://blog.sashalaundy.com/talks/askingEhelping/
• Rebecca's'Rules'for'Contruc4ve'Code'Reviews'h@ps://storify.com/ReBeccaOrg/rebeccaEsErulesEforEconstruc4veEcodeE
Photos
h"p://media.wizards.com/images/magic/daily/li/li102_mindRot.jpgh"p://www.magic=ville.com/fr/carteart?ref=cmd056h/p://archive.wizards.com/mtg/images/daily/boab/boab85iugh576f8ghadsd.jpgh"p://getwallpapers.net/magic=the=gathering=artwork=mtg=jason=chan=wallpaper=33527/h"p://teresenielsen.typepad.com/.a/6a00e54fd89cec88340147e233f3ca970b=500wi