drupal patch reviews: get good reviews, give good reviews. faster

Patch ReviewsThanks ZenDoodles and xjm

YesCTCathy Theys

@YesCTCheppers, Gittip

I review patches, mostly for core these days.

And do other stuff like plan sprints and mentor.

(https://www.youtube.com/watch?v=NvV38nJObIE&t=12m57s)

Getting patch reviewsAlso: how to find reviews

Be specific,what kind of review?

Use tagsneeds JavaScript reviewneeds architectural review,needs usability review,needs manual testing,needs screenshot

Up-to-date Issue Summaryhttps://drupal.org/contributor-tasks/write-issue-summary

Automatic instructionswork in progress at

https://drupal.org/node/2013222

Contributor taskdocuments

http://drupal.org/contributor-tasks/review

http://drupal.org/contributor-tasks/do-accessibility-review

Metas

simplytest.me urlpattern is:

/project/drupal/8.x?patch[]=

http://simplytest.me/qa#developers

Give good reviews

Doing patch reviews

Finding issues toreview

first simple! success!novice?initiativesmetas?focus?

Core initiativeshttps://drupal.org/community-initiatives/drupal-core

and https://drupal.org/node/2107085

Doing patch reviews

Full frontal nicety

Supportivespecificinclude linkssupport improvementask questionseducate

http://dreditor.org

Does it work?fixes the issuestays in scopeno regressions

Edit

Does it make sense?readable?comments?is there a better way?

StrategyScale

say whatsay how

StrategyKinds of reviews

update the issue summaryupdate needs tags

Processcannot unreadperfect is enemy of good

documentationissue summarytimein-code API docs (1354)hook_help()change records

http://drupal.org/list-changes/drupal

PerformanceDon't guessprofile!

Accessibility

bugWCAGATAGtext color contrastform fields are labeledkeyboard-usable (javascript)

UsabilityUI changes need usabilityreviewbefore and after screenshots

Testingcheck coverageask for new testsverify tests-only fails

Coding Styleno tabs, trailing1354link! to docs

drupal.org/documentation/git/interdiff

Read and checkconcerns?addressed?

read, read, readfix simplefor scopefor understanding

IDE

Resourcesdrupalize.me/guides/drupal-community-tools-and-core-mentoring

Resourcesdrupalladder.org/

Resourcesdrupal.org/contributor-tasks/reviewxjm.drupalgardens.com/review-guide

Actiondrupal mentoring office hours#drupal-contributedrupical.com

Thanks!https://drupal.org/node/2013222

https://drupal.org/core-mentoring